Align GHA workflows in the scope of report uploads#853
Conversation
mawilk90
added
the
improvement
mawilk90
requested review from
a team,
Copilot,
jriddle-linode,
lgarber-akamai,
vshanthe and
zliang-akamai
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR restricts test result uploads in the e2e-suite workflow to only occur on push events, removing uploads for pull requests and manual workflow dispatches. This aligns the integration test workflows with the project's test reporting policy.
Changes:
- Modified the
process-upload-reportjob condition to only run on push events - Removed an extraneous blank line
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi, I decided to modify a bit the condition for test report uploads because sometimes it may be reasonable to push results even on manual run - in my opinion TOD is more readable and, especially in case of some regression runs (like yesterday), it would be helpful to have reports in TOD on demand |
This reverts commit 73b4cb9. Why? Because deeper investigation proved that using boolean may lead to inconsistent behaviours.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 participants
📝 Description
GHA workflows upload test results to TOD on push, PR and manual (workflow_dispatch) runs. PR covers aligning integration test workflows to upload results automatically on push/PR and on demand for manual runs.
https://track.akamai.com/jira/browse/TPT-4190
✔️ How to Test
Manual run of the workflow should not upload test results to TOD by default.